test: fix vinyl_is_broken() check #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
requested review from
DifferentialOrange,
GRISHNOV and
Totktonada
Totktonada
reviewed
Aug 19, 2022
Totktonada
reviewed
Aug 19, 2022
Totktonada
reviewed
Aug 19, 2022
Totktonada
reviewed
Aug 19, 2022
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-103-version-check-fix
branch
5 times, most recently
from
138d256 to
1ace149
Compare
Totktonada
reviewed
Aug 19, 2022
test/unit/custom_index_test.lua
Outdated
Comment on lines
205
to
206
| t.skip_if(helpers.memtx_func_index_is_supported(), | ||
| "Doesn't blocked by https://github.com/tarantool/tarantool/issues/6786") |
There was a problem hiding this comment.
Nit: I would say something like 'no error expected with a functional index on this tarantool version, correctness is verified by another test case'. Up to you.
Totktonada
approved these changes
Aug 19, 2022
DifferentialOrange
approved these changes
Aug 23, 2022
GRISHNOV
approved these changes
Aug 24, 2022
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-103-version-check-fix
branch
3 times, most recently
from
18a474e to
760b834
Compare
The function may return true for Tarantool 2.11. It is incorrect because the bug was fixed in 2.10: ... 1.10 1.10.11-5-g40d8f4df1 ... 2.8 2.8.2-12-g2663a9c6c 2.10 2.10.0-beta1-51-g0428bbcef master 2.10.0-beta1-51-g0428bbcef The patch fixes the problem and unifies a code that checks a support of features. Closes #103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function may return true for Tarantool 2.11. It is incorrect
because the bug was fixed in 2.10:
The patch fixes the problem and unifies a code that checks a support
of features.
Closes #103