Skip to content

api: implement basic collectors#6

Merged
bigbes merged 1 commit intomasterfrom
bigbes/tntp-5717-basic-collectors
Jan 22, 2026
Merged

api: implement basic collectors#6
bigbes merged 1 commit intomasterfrom
bigbes/tntp-5717-basic-collectors

Conversation

@bigbes
Copy link
Collaborator

@bigbes bigbes commented Jan 20, 2026

Env, Map and Mock implementation.

Closes TNTP-5717

@bigbes bigbes changed the title api: implement basic collectors collectors: implement basic collectors Jan 20, 2026
@bigbes bigbes changed the title collectors: implement basic collectors api: implement basic collectors Jan 20, 2026
@bigbes bigbes force-pushed the bigbes/tntp-5716-value-api branch from 69ce8ff to 503f82a Compare January 20, 2026 01:44
@bigbes bigbes force-pushed the bigbes/tntp-5717-basic-collectors branch from b7800cd to 9db9a35 Compare January 20, 2026 01:45
@coveralls
Copy link

coveralls commented Jan 20, 2026

Pull Request Test Coverage Report for Build 21229874637

Details

  • 266 of 280 (95.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.9%) to 92.292%

Changes Missing Coverage Covered Lines Changed/Added Lines %
collectors/map.go 71 72 98.61%
internal/environ/environ.go 11 13 84.62%
internal/testutil/seq.go 0 3 0.0%
collectors/env.go 92 96 95.83%
internal/testutil/seq2.go 0 4 0.0%
Totals Coverage Status
Change from base Build 21192704361: 1.9%
Covered Lines: 922
Relevant Lines: 999

💛 - Coveralls

@bigbes bigbes force-pushed the bigbes/tntp-5716-value-api branch from 503f82a to bca1679 Compare January 21, 2026 00:37
Base automatically changed from bigbes/tntp-5716-value-api to master January 21, 2026 00:38
@bigbes bigbes marked this pull request as ready for review January 21, 2026 00:41
@bigbes bigbes force-pushed the bigbes/tntp-5717-basic-collectors branch from 9db9a35 to 3036432 Compare January 21, 2026 00:48
@bigbes bigbes force-pushed the bigbes/tntp-5717-basic-collectors branch from 3036432 to e302908 Compare January 21, 2026 23:29
Env, Map and Mock implementation.

Closes TNTP-5717
@bigbes bigbes force-pushed the bigbes/tntp-5717-basic-collectors branch from e302908 to 3db76ca Compare January 21, 2026 23:41
Copy link
Contributor

@patapenka-alexey patapenka-alexey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch!

Copy link

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch. Please, update the PR message.

@bigbes bigbes requested a review from oleg-jukovec January 22, 2026 13:13
@bigbes bigbes merged commit 1edada8 into master Jan 22, 2026
13 checks passed
@bigbes bigbes deleted the bigbes/tntp-5717-basic-collectors branch January 22, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants