api: namer implementation #18
Open
+771
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patapenka-alexey
force-pushed
the
patapenka-alexey/tntp-4190-namer-2
branch
from
c205b03 to
f7106b0
Compare
patapenka-alexey
force-pushed
the
patapenka-alexey/tntp-4190-namer-2
branch
from
f7106b0 to
436e3b8
Compare
Pull Request Test Coverage Report for Build 20173968955Details
💛 - Coveralls |
bigbes
force-pushed
the
patapenka-alexey/tntp-4190-namer-2
branch
from
d610d1e to
440c01c
Compare
Closes TNTP-4190
bigbes
force-pushed
the
patapenka-alexey/tntp-4190-namer-2
branch
from
440c01c to
9496be8
Compare
bigbes
approved these changes
Dec 12, 2025
oleg-jukovec
requested changes
Dec 12, 2025
Comment on lines
+31
to
+32
| // NewDefaultKey returns new Key object. | ||
| func NewDefaultKey(name string, keytype KeyType, property string, raw string) DefaultKey { |
Collaborator
There was a problem hiding this comment.
Tests for the type are missed.
Collaborator
There was a problem hiding this comment.
Maybe use a shortest name verify for the package?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes TNTP-4190