api: remove box.session.push usage #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laines-it
changed the title
oleg-jukovec
requested changes
Nov 8, 2025
Collaborator
oleg-jukovec
left a comment
oleg-jukovec
left a comment
There was a problem hiding this comment.
Please, rebase on the master branch and re-format the commit message (update prefix and just to make it look better):
api: removed deprecated methods
Removed `box.session.push()` usage:
* `Future.AppendPush()`, `Future.GetIterator()` methods;
* `ResponseIterator` and `TimeoutResponseIterator` types;
* `pushes[]` field in `Future` and related methods.
Closes #480
Also, it would be a good idea to clean up here:
Lines 177 to 183 in 802aa24
laines-it
force-pushed
the
laines-it/gh-480-remove-deprecated-pushapi
branch
3 times, most recently
from
9a11b11 to
e0f51d9
Compare
oleg-jukovec
requested changes
Nov 9, 2025
oleg-jukovec
changed the title
laines-it
force-pushed
the
laines-it/gh-480-remove-deprecated-pushapi
branch
2 times, most recently
from
c642651 to
7606dee
Compare
laines-it
force-pushed
the
laines-it/gh-480-remove-deprecated-pushapi
branch
from
7606dee to
dc1964d
Compare
oleg-jukovec
requested changes
Nov 12, 2025
Collaborator
oleg-jukovec
left a comment
oleg-jukovec
left a comment
There was a problem hiding this comment.
Thanks, it looks good. Let's make a few more improvements and I'll be ok.
Removed `box.session.push()` support: * `Future.AppendPush()`, `Future.GetIterator()` methods; * `ResponseIterator` and `TimeoutResponseIterator` types; * `pushes[]` field in `Future` and related methods. Connection.reader() logs message about `box.session.push` is unsupported, when it reads IPROTO_CHUNK. Closes #480
laines-it
force-pushed
the
laines-it/gh-480-remove-deprecated-pushapi
branch
from
dc1964d to
8691549
Compare
oleg-jukovec
approved these changes
Nov 12, 2025
bigbes
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
box.session.push()usage:Future.AppendPush(),Future.GetIterator()methods,ResponseIteratorandTimeoutResponseIteratortypes,pushes[]field inFutureand related methods.Removed tests which became unnecessary.
I didn't forget about (remove if it is not applicable):
Closes #480