Dashboard defaults #173
Merged
Dashboard defaults #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
approved these changes
Aug 3, 2022
| type='constant', | ||
| pluginId=null, | ||
| pluginName=null, | ||
| value='tarantool', |
There was a problem hiding this comment.
As far as I understand this is the default value for a user input? Does it make sense to change it too with the JOB value?
There was a problem hiding this comment.
Templating dashboards are built as part of tests, they do not have separate make tests and are built with libsonnet module imports.
Set default Prometheus job to "tarantool". After this patch, it will be possible to import dashboard with community.ansible.ansible_dashboard, if Prometheus is configured to collect Tarantool metrics with "tarantool" job. This patch also changes all examples job names to "tarantool". Part of #138
Set default InfluxDB measurement to "tarantool_http". After this patch, it will be possible to import dashboard with community.ansible.ansible_dashboard, if Telegraf is configured to collect Tarantool metrics with http plugin and "tarantool_" prefix. This patch also changes all examples measurement names to "tarantool_http". Closes #138
DifferentialOrange
force-pushed
the
DifferentialOrange/138-default-job
branch
from
8094b7a to
001bbf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dashboard: set default Prometheus job
Set default Prometheus job to
tarantool. After this patch, it will be possible to import dashboard withcommunity.ansible.ansible_dashboard, if Prometheus is configured to collect Tarantool metrics withtarantool` job.
This patch also changes all examples job names to
tarantool.dashboard: set default InfluxDB measurement
Set default InfluxDB measurement to
tarantool_http. After this patch, it will be possible to import dashboard withcommunity.ansible.ansible_dashboard, if Telegraf is configured to collect Tarantool metrics withhttpplugin andtarantool_prefix.This patch also changes all examples measurement names to
tarantool_http.Closes #138