Fix returning data and error for multiple resolvers #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegrok
approved these changes
Nov 15, 2021
Totktonada
reviewed
Nov 17, 2021
32c97f0 introduced returning data and errors acc. spec #7.1.2 but previous implementation didn't take into account that execution may include multiple resolvers and each of them may return both data and errors. This PR fixes the logic to collect all errors from all resolvers into a single array that can be returned to requester. Based on PR #19 by @no1seman
DifferentialOrange
force-pushed
the
DifferentialOrange/no1seman-data_errors_improved
branch
from
697e928 to
c4d03b7
Compare
|
Resolved all minor comments. PR is ready to merge |
Totktonada
deleted the
DifferentialOrange/no1seman-data_errors_improved
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework of #19 . Additional test was reworked so both resolvers return error. Added description to commit message, removed #18 commit from PR.