Fix rockspec and version injection #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follows up #29
There are two reasons: * The module is written purely in Lua (without Lua/C parts) and nothing blocks us from deliver .all.rock. There is no much difference for this module, but .src.rock is usually something to compile before installation. See [1] for details. * We can't write a version into the `graphql/init.lua` file for .src.rock. Steps to illustrate what does not work with .src.rock: * Step into the git repository. * Rewrite `graphql/init.lua`. * `tarantoolctl rocks new_version --tag $TAG` - Creates a rockspec with `source.tag = $TAG`. * `tarantoolctl rocks pack graphql-$TAG-1.rockspec` - Downloads a fresh (unmodified) source from the git tag. - Packs the unmodified sources into .src.rock. The steps differ, when we're pack into .all.rock: * <...> * `tarantoolctl rocks make graphql-$TAG-1.rockspec` - Installs the modified content of the git repository into `.rocks`. * `tarantoolctl rocks pack graphql $TAG` - Packs the modified content from `.rocks` into .all.rock. [1]: https://github.com/luarocks/luarocks/wiki/Types-of-rocks Follows up #29
I guess it should ease scripting around the version string. Also changed `'scm-1'` to `'unknown'`, because we actually don't know a way how the module is installed: loaded from a local git clone, extracted from a release .zip archive generated by GitHub or actually installed from the scm-1 rockspec. In all those variants `graphql.VERSION` will return the same predefined string. Modified the test to make it independent of a module installation variant. I don't meet any real problem here, it just looks more durable. Follows up #29
Before this change I had to manually upload a new scm-1 rockpec to the rocks server after pushing an update to the git repository. Now it is automated. Follows up #29
|
There are several alternatives:
The unobvious thing about first two options is that they only work while So I prefer the simple and explicit variant and propose it here. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset should actually finish the implementatoin of the
graphql.VERSIONstring generation.Follows up #29.