cmake: fail early if no module.h found#5
Merged
Totktonada merged 1 commit intomasterfrom Oct 16, 2021
Merged
Conversation
Commit 58d39d7 ('cmake: fix warning') causes a little regression: if there is no tarantool/module.h header, we should fail at the cmake stage. After the fix of the warning we'll fail only at the building stage (when `make` is called). Here I return the old behaviour (fail on the `cmake` stage) back. See tarantool/tuple-keydef#20
olegrok
approved these changes
Oct 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 58d39d7 ('cmake: fix warning')
causes a little regression: if there is no tarantool/module.h header, we
should fail at the cmake stage. After the fix of the warning we'll fail
only at the building stage (when
makeis called). Here I return theold behaviour (fail on the
cmakestage) back.See tarantool/tuple-keydef#20