-
Notifications
You must be signed in to change notification settings - Fork 12
Raise an error when non-array arguments passed to the server:exec
#287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise an error when non-array arguments passed to the server:exec
#287
Conversation
71fd99e to
d7642b9
Compare
d7642b9 to
12d23ec
Compare
a62ee8d to
d9ed0d8
Compare
|
@sergepetrenko , hi! Everything else (logging) remained unchanged. |
sergepetrenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
Looks good. Only one note from me.
35741a5 to
175db2d
Compare
|
I don't really like the current version, but I don't know yet how to work more comfortably with the |
1425756 to
003b449
Compare
003b449 to
d8dc120
Compare
server:exec
d8dc120 to
c044c9e
Compare
An error will be raised if the non-array arguments have been passed to the `server:exec()`. Resolves tarantool#230
c044c9e to
4fda84c
Compare
ylobankov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Due to the specifics of the
unpackfunction in theserver:exec()method an array structure check has been added. An error will be raised if the arguments are not an array.Normal cases
Number of items and structure length
Due to the specific and non-deterministic
#method, we cannot use this table attribute.These cases will be skipped and will not be checked.
Corner case with shifting arguments
Luatestwill give an error:Resolves #230