Make assert_covers check array items for coverage
#440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treating arrays as maps in `assert_covers` is error-prone so we fixed it in commit 95a1c3f ("Fix `assert_covers` treat arrays as maps"), but we did it over-zealously - now arrays are treated just like scalars (numbers, for example). This breaks the case when array items are supposed to be checked for coverage for example: ```lua t.assert_covers({ {a = 1, b = 10}, {a = 2, b = 20}, {a = 3, b = 30}, }, {{a = 1}, {a = 2}, {a = 3}}) ``` Fix this. Follow-up tarantool#405 Closes tarantool#439
mandesero
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treating arrays as maps in
assert_coversis error-prone so we fixed it in commit 95a1c3f ("Fixassert_coverstreat arrays as maps"), but we did it over-zealously - now arrays are treated just like scalars (numbers, for example). This breaks the case when array items are supposed to be checked for coverage for example:Fix this.
Follow-up #405
Closes #439