Skip to content

msgpack-lite: fix BigInteger pack / unpack #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2019
Merged

msgpack-lite: fix BigInteger pack / unpack #121

merged 1 commit into from
Jan 28, 2019

Conversation

@Totktonada
Copy link

@Totktonada Totktonada commented Jan 23, 2019

Fixes #27.

@Totktonada Totktonada added the bug Something isn't working label Jan 23, 2019
@Totktonada
Copy link
Author

Totktonada commented Jan 23, 2019

@dgreenru @ponomarevDmitri It would be glad if you will review this patch.

@isopov Ivan, can you please look into this PR too (cannot assign you as the reviewer).

@coveralls
Copy link

coveralls commented Jan 23, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 116

  • 15 of 16 (93.75%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 62.596%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/org/tarantool/MsgPackLite.java 15 16 93.75%
Files with Coverage Reduction New Missed Lines %
src/main/java/org/tarantool/TarantoolClusterClient.java 2 74.67%
Totals Coverage Status
Change from base Build 108: 0.3%
Covered Lines: 1307
Relevant Lines: 2088
💛 - Coveralls

ponomarevDmitri
ponomarevDmitri reviewed Jan 27, 2019
View reviewed changes
@Totktonada
Copy link
Author

Totktonada commented Jan 28, 2019

NB: Filed #127 to cover msgpack-lite with unit tests.

@Totktonada Totktonada force-pushed the Totktonada/gh-27-fix-biginteger-pack-unpack branch from f0b92cb to 1f8b981 Compare January 28, 2019 11:58
@Totktonada Totktonada merged commit 1e7fc18 into master Jan 28, 2019
@Totktonada Totktonada deleted the Totktonada/gh-27-fix-biginteger-pack-unpack branch January 28, 2019 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@isopov isopov isopov approved these changes

@dmitry-grytsovets dmitry-grytsovets dmitry-grytsovets approved these changes

@ponomarevDmitri ponomarevDmitri ponomarevDmitri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Totktonada @coveralls @isopov @dmitry-grytsovets @ponomarevDmitri