Skip to content

changed frequent logs #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmcecilia3 merged 6 commits into from
Feb 17, 2026
Merged

changed frequent logs #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
de66a96
changed frequent logs
arpal7 Feb 9, 2026
eef488c
removing change to test logging behavior
arpal7 Feb 16, 2026
f4cee87
updated code
arpal7 Feb 17, 2026
d6d4c47
commented the changes
arpal7 Feb 17, 2026
2cfcd6d
one change back
arpal7 Feb 17, 2026
ffa0c7c
added change back
arpal7 Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 36 additions & 2 deletions src/main/java/com/target/devicemanager/components/scanner/ScannerController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import org.springframework.web.bind.annotation.*;

import java.util.List;
import java.util.Objects;

@RestController
@RequestMapping(value = "/v1")
Expand Down Expand Up @@ -61,7 +62,24 @@ public Barcode getScannerData(@Parameter(description = "Scanner to Call") @PathV
log.successAPI("API Request Completed Successfully", 1, url, data == null ? null : data.toString(), 200);
return data;
} catch (ScannerException scannerException) {
log.failureAPI("API Request Failed with ScannerException", 13, url, scannerException.getDeviceError() == null ? null : scannerException.getDeviceError().toString(), scannerException.getDeviceError() == null ? 0 : scannerException.getDeviceError().getStatusCode().value(), scannerException);
// If getCode() is DISABLED or DEVICE_BUSY, it means the scan request was cancelled either by the client or due to another scan request, so we log it as a less severe failure than other exceptions
DeviceError error = scannerException.getDeviceError();
String code = error != null ? error.getCode() : null;
int status = (error != null && error.getStatusCode() != null)
? error.getStatusCode().value()
: 0;

int severity = (!Objects.equals(code, "DISABLED") &&
!Objects.equals(code, "DEVICE_BUSY")) ? 13 : 1;

log.failureAPI(
"API Request Failed with ScannerException",
severity,
url,
error != null ? error.toString() : null,
status,
scannerException
);
throw scannerException;
}
} else {
Expand Down Expand Up @@ -92,7 +110,23 @@ public void cancelScanRequest() throws ScannerException {
scannerManager.cancelScanRequest();
log.successAPI("API Request Completed Successfully", 1, url, "OK", 200);
} catch (ScannerException scannerException) {
log.failureAPI("API Request Failed with ScannerException", 13, url, scannerException.getDeviceError() == null ? null : scannerException.getDeviceError().toString(), scannerException.getDeviceError() == null ? 0 : scannerException.getDeviceError().getStatusCode().value(), scannerException);
// If getCode() is ALREADY_DISABLED, it means the scan request was already cancelled before this call, so we log it as a less severe failure than other exceptions
DeviceError error = scannerException.getDeviceError();
String code = error != null ? error.getCode() : null;
int status = (error != null && error.getStatusCode() != null)
? error.getStatusCode().value()
: 0;

int severity = !Objects.equals(code, "ALREADY_DISABLED") ? 13 : 1;

log.failureAPI(
"API Request Failed with ScannerException",
severity,
url,
error != null ? error.toString() : null,
status,
scannerException
);
throw scannerException;
}
}
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/com/target/devicemanager/components/scanner/ScannerDevice.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ public Void cancelScannerData() {
try{
disable();
} catch(JposException jposException){
log.failure("Received exception in cancelScannerData", 17, jposException);
log.failure("Received exception in cancelScannerData", 1, jposException);
} finally {
deviceListener.stopWaitingForData();
}
Expand Down Expand Up @@ -248,7 +248,7 @@ protected void enable() throws JposException {
throw jposException;
}
}
log.success(getScannerType() + " scanner enabled", 9);
log.success(getScannerType() + " scanner enabled", 1);
log.success(getScannerType() + " enable(out)", 1);
}

Expand Down Expand Up @@ -276,7 +276,7 @@ private void disable() throws JposException {
throw jposException;
}
}
log.success(getScannerType() + " scanner disabled", 9);
log.success(getScannerType() + " scanner disabled", 1);
log.success(getScannerType() + " disable(out)", 1);
}

Expand Down