added printer localFuture handling#87
Merged
Merged
Conversation
arpal7
requested review from
AwesomestChris,
LizZhang-00,
bmcecilia3 and
rrenkor
LizZhang-00
reviewed
Mar 9, 2026
Collaborator
LizZhang-00
left a comment
LizZhang-00
left a comment
There was a problem hiding this comment.
Looks to me we don't need isTest anymore.
LizZhang-00
approved these changes
Mar 9, 2026
rrenkor
approved these changes
Mar 9, 2026
bmcecilia3
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Description of testing:
Please make sure the following changes have been made before creating a pull request.
Update
DescriptionChange tested on actual deviceChanges tested for simulatorExisting device functionality is working fineUnit Tests Written for Code Changes, and Verified that Coverage is 100% for Modified Files(with the exception of ATM devices)