Skip to content

Printer issue analysis fix#88

Merged
bmcecilia3 merged 8 commits intomainfrom
printerIssueAnalysisFix
Apr 13, 2026
Merged

Printer issue analysis fix#88
bmcecilia3 merged 8 commits intomainfrom
printerIssueAnalysisFix

Conversation

@arpal7
Copy link
Copy Markdown
Contributor

@arpal7 arpal7 commented Mar 27, 2026

Description of changes:

Description of testing:

Please make sure the following changes have been made before creating a pull request.

Update Description

  • Change tested on actual device
  • Changes tested for simulator
  • Existing device functionality is working fine
  • Unit Tests Written for Code Changes, and Verified that Coverage is 100% for Modified Files(with the exception of ATM devices)

log.failure("Inner timeout recovery: reconnecting (attempt " + attempt + ")", 17, null);
boolean success = connect();
if (success) {
log.failure("Inner timeout recovery: printer reconnected successfully", 5, null);
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log.success?

Comment thread src/main/java/com/target/devicemanager/components/printer/PrinterDevice.java Outdated
return;
}
if (!recoveryInProgress.compareAndSet(false, true)) {
log.failure("forceUnlock: inner timeout recovery already in progress — skipping duplicate disconnect", 5, null);

This comment was marked as resolved.

@arpal7 arpal7 requested review from bmcecilia3 and rrenkor April 13, 2026 20:03
@bmcecilia3 bmcecilia3 merged commit b64c31d into main Apr 13, 2026
@bmcecilia3 bmcecilia3 deleted the printerIssueAnalysisFix branch April 13, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants