feat: support regex capture groups as arguments#276
Merged
wass3r merged 2 commits intotarget:mainfrom Jun 28, 2022
Merged
Conversation
Pull Request Test Coverage Report for Build 2543700057
💛 - Coveralls |
wass3r
approved these changes
Jun 25, 2022
wass3r
approved these changes
Jun 25, 2022
Collaborator
wass3r
left a comment
There was a problem hiding this comment.
thanks a ton. let us know if you're adding to docs, otherwise i'll make a story to do so.
Contributor
Author
|
Here's an accompanying PR for documentation: target/flottbot-docs#57 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This change adds support for regex capture groups as input arguments (closes #10). It does so by taking advantage of named & numbered capture groups in the standard library.
This can be used in both "respond" and "hear" rules. Doing so adds argument support for "hear" rules, discussed in #204.
In the following example, the capture group named
wordis processed as an argument with the same name.See the unit tests for more detailed examples.
Types of changes
Checklist