Misc. fixes, some from Debian/Ubuntu #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The allocation on line 1032 is created via Tcl_SplitList, and so it must be freed with Tcl_Free rather than bare free. ``` 1032 if (Tcl_SplitList(interp, argv[2], &listc, &listv) != TCL_OK) ``` This change is adapted from https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1075067
GCC 14 now enforces strict cv-qualifier check by default. This patch fixes all the cv-qualifier violations. This change is adapted from https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1075067
fargv is allocated by hfs_glob so it must be freed by free, not Tcl_Free. ``` 1036 fargv = hfs_glob(vol, listc, listv, &fargc); ```
A Unix file descriptor number is stored in the
"generic callback argument" `void **priv`. However, on LP64
systems like x86_64 linux, `int` and `void **` have different size.
This leads to a compiler diagnostic:
```
os.c: In function ‘os_write’:
os.c:192:12: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
192 | int fd = (int) *priv;
| ^
```
Adding an additional cast via `intptr_t` resolves the compiler
diagnostics.
Direct access to interp->result has been deprecated for a long
time. Fix it.
* Where the result is being read, use Tcl_GetStringResult
* Where the result is being written, use Tcl_SetResult
* Where it is being written from a printf format string, use
a wrapper function "resultf".
* In each case, ensure the correct free function is
passed (static, dynamic, or volatile)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not possible to build hfsutils on gcc 14.1, which "enforces strict cv-qualifier check by default."
This PR incorporates:
os.crelated to casting between int and ptrinterp->result