feat: per-network config with --network override by sdbondi · Pull Request #126 · tari-project/tari-cli

sdbondi · 2026-04-21T14:03:42Z

Summary

Nest wallet-daemon-url, metadata-server-url, and template-address under [networks.<name>] sections in both project (tari.config.toml) and global CLI config, keyed by the Network enum from tari_ootle_common_types.
Add a default-network setting (defaults to esmeralda) and a global -n/--network <NETWORK> flag that overrides it on any command.
Active network resolution: --network flag → project default-network → global default-network → Esmeralda. Wallet daemon URL, metadata server URL, and template address all look up the resolved network's section, with per-command URL flags still winning.
Default wallet daemon URL for esmeralda is http://127.0.0.1:5100/json_rpc (unchanged from the previous flat default).
tari config set generalised to arbitrary dotted-key depth so networks.<net>.wallet-daemon-url works.

Default project config now emits:

default-network = "esmeralda"
                                                                                                                                                                                                                                                                                                                                    
  [networks.esmeralda]                                                                                                                                                                                                                                                                                                                          
  wallet-daemon-url = "http://127.0.0.1:5100/json_rpc"                                                                                                                                                                                                                                                                                          
  metadata-server-url = "..."                                                                                                                                                                                                                                                                                
                                                                                                                                                                                                                                                                                                                                                
  [networks.localnet]
  wallet-daemon-url = "http://127.0.0.1:5100/json_rpc"                                                                                                                                                                                                                                                                                          
  metadata-server-url = "http://localhost:3000/"

No backwards-compat shim — existing flat tari.config.toml files will need tari config init or a manual edit.

Test plan

cargo test --workspace passes (new roundtrip + per-network parse tests added).
tari config init emits the new layout (verified locally).
tari config set networks.localnet.wallet-daemon-url … / tari config get … round-trip through the deeper dotted-key setter.
tari --network bogus publish rejects invalid networks via clap.
--network shows up in both tari --help and tari publish --help (global = true).
Manual test: tari publish against a running esmeralda wallet daemon (not run in CI).
Manual test: tari --network localnet publish with a [networks.localnet] section in project config.

🤖 Generated with Claude Code

Restructure both project (tari.config.toml) and global CLI configs to nest wallet-daemon URL, metadata-server URL, and template-address under [networks.<name>] sections, keyed by the Network enum from tari_ootle_common_types. Add a default-network setting and a global -n/--network flag that overrides it on any command. Resolution order for the active network: --network flag > project default-network > global default-network > Esmeralda. Wallet daemon URL, metadata server URL, and template address all look up the resolved network's section, with per-command URL flags still winning. Default project config now emits: default-network = "esmeralda" [networks.esmeralda] wallet-daemon-url = "http://127.0.0.1:5100/json_rpc" `tari config set` was generalised to arbitrary dotted-key depth so that `networks.<net>.wallet-daemon-url` works. No migration shim: existing flat `tari.config.toml` files will need `tari config init` or a manual edit.

gemini-code-assist

Code Review

This pull request introduces multi-network support to the Tari CLI, refactoring configuration structures to allow per-network settings for wallet daemon URLs, metadata server URLs, and published template addresses. It adds a global --network flag and implements a resolution hierarchy across CLI flags, project configurations, and global settings. Feedback focuses on the lack of validation between the CLI-resolved network and the network reported by the wallet daemon, which could lead to incorrect configuration updates. Additionally, there are concerns regarding code duplication between save_template_address and set_dotted_key, a regression in the global override mechanism for network-specific settings, and the preference for implicit tables in TOML generation to maintain a cleaner configuration file.

gemini-code-assist · 2026-04-21T14:06:24Z

+    let info = publisher
+        .get_wallet_info()
+        .await
+        .with_context(|| anyhow!("Failed to connect to the wallet at {}", wallet_daemon_url))?;
    println!(
-        "🔗 Connected to wallet version {} (network: {})",
+        "🔗 Connected to wallet version {} (wallet network: {})",
        info.version, info.network
    );


There is no validation that the network reported by the wallet daemon matches the network resolved by the CLI. This can lead to templates being published to a different network than intended (e.g., if the CLI is set to mainnet but the wallet is on esmeralda), while the CLI records the resulting address under the wrong network section in the configuration file. It is recommended to verify that info.network matches the resolved network before proceeding.

gemini-code-assist · 2026-04-21T14:06:24Z

+    let root = doc
+        .entry(head[0])
+        .or_insert_with(|| toml_edit::Item::Table(toml_edit::Table::new()))
+        .as_table_mut()
+        .ok_or_else(|| anyhow!("'{}' is not a table", head[0]))?;
+
+    let mut table = root;
+    for part in &head[1..] {
+        let entry = table
+            .entry(part)
+            .or_insert_with(|| toml_edit::Item::Table(toml_edit::Table::new()));
+        table = entry
+            .as_table_mut()
+            .ok_or_else(|| anyhow!("'{part}' is not a table"))?;
+    }
+    table.insert(leaf, toml_edit::value(value));


The current implementation of set_dotted_key creates intermediate tables as explicit tables, which can lead to a cluttered TOML file with multiple headers (e.g., [networks], [networks.esmeralda]). It is generally preferred to use implicit tables for nested structures. Additionally, the logic can be simplified by iterating over all parts of the 'head' using the root table of the document.

References

Prefer implicit tables for nested TOML structures to maintain a clean configuration layout. ^(link)

gemini-code-assist · 2026-04-21T14:06:24Z

 pub const VALID_OVERRIDE_KEYS: &[&str] = &[
    "template_repository.url",
    "template_repository.branch",
    "template_repository.folder",
    "default_account",
-    "wallet_daemon_url",
-    "metadata_server_url",
+    "default_network",
 ];


Removing wallet_daemon_url and metadata_server_url from VALID_OVERRIDE_KEYS is a regression that breaks the ability to override these settings via the global -e flag. While command-specific flags exist, the -e flag was a useful catch-all. Furthermore, the -e flag logic in override_data remains flat and does not support the new nested configuration keys (e.g., networks.esmeralda.wallet-daemon-url), even though the tari config set command was generalized to support them. The global override mechanism should be updated to support the new structure or at least maintain backward compatibility for the old keys by mapping them to the default network.

gemini-code-assist · 2026-04-21T14:06:24Z

+fn save_template_address(doc: &mut toml_edit::DocumentMut, network: Network, address: &str) {
+    let networks = doc
+        .entry("networks")
+        .or_insert_with(|| toml_edit::Item::Table(toml_edit::Table::new()));
+    let Some(networks_table) = networks.as_table_mut() else {
+        // Not a table — overwrite.
+        *networks = toml_edit::Item::Table(toml_edit::Table::new());
+        return save_template_address(doc, network, address);
+    };
+    networks_table.set_implicit(true);
+
+    let net_entry = networks_table
+        .entry(network.as_key_str())
+        .or_insert_with(|| toml_edit::Item::Table(toml_edit::Table::new()));
+    let net_table = match net_entry.as_table_mut() {
+        Some(t) => t,
+        None => {
+            *net_entry = toml_edit::Item::Table(toml_edit::Table::new());
+            net_entry.as_table_mut().unwrap()
+        },
+    };
+    net_table.insert("template-address", toml_edit::value(address.to_string()));
+}


The save_template_address function duplicates much of the logic found in the generalized set_dotted_key function in crates/cli/src/cli/commands/config.rs. Consolidating this logic into a shared utility would improve maintainability and ensure that configuration file modifications (such as setting tables to implicit) are performed consistently across the CLI.

Default project and global configs now ship both [networks.esmeralda] and [networks.localnet] sections so users can switch with `--network localnet` without first editing the config. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Default project and global configs now write a metadata-server-url under each per-network section: esmeralda → https://ootle-templates-esme.tari.com/ localnet → http://localhost:3000 Both URLs are defined as single-source-of-truth constants in project/config.rs and reused by the in-memory fallback in util.rs. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

- Validate wallet daemon network matches the CLI-resolved active network before publishing; abort with a clear error if they differ. - Restore -e overrides for nested keys: networks.<net>.wallet-daemon-url and networks.<net>.metadata-server-url. Switch the parser to split_once so values containing '=' are preserved. - Share set_dotted_key between `tari config set` and the post-publish template-address writer (drops the duplicated save_template_address). - Mark intermediate TOML tables implicit so nested structures render as `[networks.esmeralda]` instead of `[networks]\n[networks.esmeralda]`. - Update README and all docs (configuration-schema, cli-commands, workflow, project-configuration, deployment, faq, etc.) to the new per-network shape and document the --network flag. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

gemini-code-assist Bot reviewed Apr 21, 2026

View reviewed changes

sdbondi and others added 4 commits April 22, 2026 14:40

fmt

ce1b79b

sdbondi merged commit db8b867 into main Apr 22, 2026
4 of 6 checks passed

sdbondi deleted the feat/per-network-config branch April 22, 2026 12:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: per-network config with --network override#126

feat: per-network config with --network override#126
sdbondi merged 5 commits into
mainfrom
feat/per-network-config

sdbondi commented Apr 21, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Apr 21, 2026

Uh oh!

gemini-code-assist Bot Apr 21, 2026

Uh oh!

gemini-code-assist Bot Apr 21, 2026

Uh oh!

gemini-code-assist Bot Apr 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

sdbondi commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sdbondi commented Apr 21, 2026 •

edited

Loading