Skip to content

Added --output option to redirect olly printing#5

Merged
kayceesrk merged 3 commits intotarides:mainfrom
ElectreAAS:main
Sep 23, 2022
Merged

Added --output option to redirect olly printing#5
kayceesrk merged 3 commits intotarides:mainfrom
ElectreAAS:main

Conversation

@ElectreAAS
Copy link
Copy Markdown

This will come in handy for this sandmark issue

Comment thread bin/olly.ml

let output_option =
let doc =
"Redirect the output of `olly` to specified file. The output of the \
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "output of the command is not redirected" mean?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If prog.exe prints on stdout and/or stderr, then olly latency -o some_file prog.exe will print the latency info in some_file, but the original prints will still go to stdout/stderr

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be useful to add a description in the PR message to indicate how this command works like ^^.

@ElectreAAS ElectreAAS marked this pull request as draft September 2, 2022 15:47
@ElectreAAS
Copy link
Copy Markdown
Author

Just realized my shenanigans with the filename make little sense in olly, I'll stick to making a more precise script in sandmark

@ElectreAAS ElectreAAS marked this pull request as ready for review September 2, 2022 17:00
@ElectreAAS
Copy link
Copy Markdown
Author

My last commit here is a partial revert, as I remove the printing of the name altogether. It was messy and in our use-case where exec_args contained something like taskset ... actual_command, only taskset was being printed.
The functionality has been moved in the bash script in sandmark, as per my latest commit on the sandmark PR

@kayceesrk kayceesrk merged commit 09630b6 into tarides:main Sep 23, 2022
Copy link
Copy Markdown
Collaborator

@kayceesrk kayceesrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sudha247 added a commit to Sudha247/opam-repository that referenced this pull request May 31, 2023
CHANGES:

* Fix dependencies (tarides/runtime_events_tools#14, @Sudha247)
* Improve JSON output produced by olly gc-stats (tarides/runtime_events_tools#13, @punchagan)
* Mention Fuchsia format in the README (tarides/runtime_events_tools#11, @Sudha247)
* Gc subcommand (tarides/runtime_events_tools#10, @Sudha247)
* Add Fuchsia Trace Format output to olly (tarides/runtime_events_tools#6, @tomjridge)
* Added --output option to redirect olly printing (tarides/runtime_events_tools#5, @ElectreAAS)
* Added json printing option (tarides/runtime_events_tools#4, @ElectreAAS)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants