Skip to content

Include and install patched pi-diff-review extension #3

@knocte

Description

@knocte

With skynot setup (running Pi with a pi user, which doesn't have GUI access), pi-diff-review extension (https://github.com/badlogic/pi-diff-review) doesn't work because this extension tries to open a browser instance.

We should create a PR for skynot that:

  • Adds https://github.com/badlogic/pi-diff-review as a submodule.
  • As part of its npm run exec routine (or npx after it has been published in npm), it clones the submodule.
  • After cloning the submodule, it makes a few-lines modification of its sources (i.e. having a .patch file inside the repo and using patch -i on it), to just print the URL of the website that it would have opened in the browser (so that the user of Pi can copy the link from the terminal and open the browser manually).
  • It should install the modified extension inside the pi user's $HOME.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions