Conversation
Core & Database: - Integrated new raw SQL Server execution transcript details for deeper query debugging. - Added 'QueryStatementClassifier' for intelligent statement-level analysis. - Introduced 'PostgresTerminalLauncher' for native psql integration. - Enhanced 'DatabaseProtocols' and 'QueryResultsModels' to support richer metadata. UI & Design System: - Refactored 'SignedInAccountCard' into modular components (+Bindings, +Components, +Sheets). - Replaced specialized tab factory with a modular system (Monitor, Security, ServerTools). - Extracted 'FolderEditorSheet' into logically separated extensions. - Added 'ExperimentalObjectBrowser' — a high-performance sidebar using NSOutlineView. - Integrated high-fidelity database icons for SQL Server, Postgres, MySQL, and SQLite. - Added 'TableStructureToolbarItem' and new coordinator for table structure editing. Features: - Sync & Account: Major refactor of SyncEngine including initial sync logic and merge strategy sheets. - Object Browser Cache: Added 'ObjectBrowserCacheStore' for persistent metadata caching. - Table Structure Editor: Significant refactor of the editor and its sheets (+Draft, +Logic, +Review). - Preferences: Enhanced Notification and Cache settings views. - Data Migration: Added SQL generation and action logic to the migration wizard. Tests & Documentation: - Updated README with modern design and architectural overview. - Added comprehensive unit tests for Apple Sign-In, Object Browser Cache, and Statement Classification. - Fixed metadata freshness logic in 'ConnectionSessionTests'. Dependencies: - Updated 'Package.resolved' to consume the latest 'postgres-wire' and 'sqlserver-nio' revisions.
The hardcoded 64MB minimum in 'pruneToLimit' was preventing the unit tests from verifying the LRU pruning behavior with small test data. Removed the minimum to allow granular control over cache limits.
Marked test methods as @mainactor to ensure they run on the same actor as the picker's static utility methods. This prevents data races and crashes observed in the CI environment when accessing actor-isolated static properties from background threads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core & Database:
UI & Design System:
Features:
Tests & Documentation:
Dependencies: