Conversation
…d factory file and cleanup internal files
…l actions by removing monolithic file
…ar with new sidebar SQL Server 2008 R2 compat: - Gate temporal/memory-optimized SQL on serverMajorVersion from LOGINACK (already shipped to sqlserver-nio dev branch) Column expansion fix (ExperimentalObjectBrowserSidebarView is now canonical): - Add .column row case to ObjectBrowserNode so table/view nodes include column children when object.columns is non-empty - Render column rows via DatabaseObjectColumnRow in ObjectBrowserRowView - Show expand chevron on table/view rows only when columns are present - Handle .column in all exhaustive switch statements Freshness / snapshot fixes: - hydrateMetadataFreshnessFromCacheStructure: mark databases as .listOnly when cached objects have no column data (requireColumns check) so the background prefetch reloads them - Gate .live freshness only when column data is confirmed present Sidebar consolidation: - Remove old ObjectBrowserSidebarView (40+ view files) and its supporting DatabaseObjectBrowserView / DatabaseObjectRow components - Rename ExperimentalObjectBrowserSidebarView → ObjectBrowserSidebarView (all Experimental* types renamed accordingly across all files) - Both .folder and .experimentalFolder nav cases now use ObjectBrowserSidebarView - Remove orphaned ExplorerSidebarViewModel+Replication.swift Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…WHERE clause test Bumps sqlserver-nio to cf7d65b which fixes TDSData.uuid, SQLServerValue.init(uuid:), and SQLServerRow.toStringArray() to correctly apply SQL Server's mixed-endian byte swap. GUIDs displayed in the query editor were showing the wrong value; copying one into a WHERE clause returned zero rows. Adds testUniqueidentifierWhereClause to catch this: inserts a known UUID, reads it back, confirms the displayed string matches the original, then queries by the displayed value and asserts exactly one row is returned. Also strengthens testUniqueidentifierRoundTrip to verify the actual GUID values round-trip correctly instead of only checking count and uniqueness. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…use test Used .nvarchar(length: .length(50)) instead of the incorrect .nvarchar with a plain Int length argument, fixing the CI build failure. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…wserSidebarViewModel The property was accidentally dropped during a refactor, breaking the DatabaseSnapshotsSidebarTests build and causing CI (Light) to fail. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
hydrateMetadataFreshnessFromCacheStructure() requires at least one table/view to have column data before marking a database as .cached. The test fixture used the no-column default, so the "loaded" database was always classified as .listOnly, failing the assertion. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
hydrateMetadataFreshnessFromCacheStructure uses loadedState: .live so that databases restored from cache expand instantly without a background fetch. The test expectation was stale (.cached). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.