Conversation
Recent Z2M replaced the legacy interviewing/interview_completed boolean pair on device records with a single interview_state enum (PENDING / IN_PROGRESS / SUCCESSFUL / FAILED). The legacy fields can stay false on fully-online devices, which made DeviceRowView show "Interviewing" while DeviceCard correctly showed "Online" — same data, two different reads. Add Device.interviewState plus a single Device.isInterviewing accessor that prefers the new enum and falls back to the legacy pair, then route every existing call site (rows, cards, footer, list filters, recents, network analysis, home snapshot, pairing wizard) through it. Mirror the new enum on device_interview events so optimistic updates also clear. Seeder fixtures and join scenario emit interview_state for parity. Fixes #101 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
interviewing/interview_completedboolean pair on device records with a singleinterview_stateenum (PENDING/IN_PROGRESS/SUCCESSFUL/FAILED). The legacy fields can stayfalseon fully-online devices, which made the device list row show "Interviewing" while the device card correctly showed "Online" — same data, two different reads.interview_stateonDevice, add a singleDevice.isInterviewingaccessor that prefers the new enum and falls back to the legacy pair, and route every call site through it (rows, cards, footer, list filters, recents, network analysis, home snapshot, pairing wizard).device_interviewevents so optimistic updates also clear. Seeder fixtures + join scenario emitinterview_statefor parity.Closes #101
Test plan
failedjoin (device/joinwithfail=true); confirm row + card both leave "Interviewing".interview_stateand confirm a paired device no longer reads "Interviewing" on the list once online.Waiting/Interviewing/Ready) tracks correctly.🤖 Generated with Claude Code