Conversation
LogsView wraps itself in its own NavigationStack and is pushed inside the Settings tab's stack. SwiftUI's behaviour with nested NavigationStacks is inconsistent: NavigationLink(value:) pushes from inside the nested stack can silently route to the *outer* stack, which in this case had no DeviceRoute / GroupRoute handler. Result: tapping the device/group hero card on a log opened via Settings → Logs did nothing — the user perceived it as being dropped back to the tab root. Register the same handlers on SettingsView and BridgeSettingsView NavigationStacks as a safety net so the push lands correctly no matter which enclosing stack SwiftUI picks. The handlers inside LogsView's own stack are kept too, so the in-tab Logs path also still works. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Build on main at commit 4ab988c still failed with ITMS-90035 invalid signature. This enforces distribution identity explicitly for device archives in Xcode Cloud.