Skip to content

fix click outside #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bersling merged 2 commits into from
Dec 10, 2020
Merged

fix click outside #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5e51da
fix click outside
daniel-taskbase Dec 10, 2020
ab209d7
bump the version
daniel-taskbase Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/angular-keyboard/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@taskbase/angular-keyboard",
"version": "0.0.7",
"version": "0.0.8",
"peerDependencies": {
"@angular/common": "^8.1.3",
"@angular/core": "^8.1.3"
Expand Down
11 changes: 10 additions & 1 deletion projects/angular-keyboard/src/lib/keyboard-container/keyboard-container.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,16 @@ export class KeyboardContainerComponent implements OnInit, OnDestroy {

onClickOnPage(e) {
const isFakeInput = this.angularKeyboardService.inputFields
.map(fakeInputElt => isAncestor(e.target, fakeInputElt.nativeElement))
.map(fakeInputElt => {
try {
// Check if the fake input element is an ancestor of the clicked element
return isAncestor(e.target, fakeInputElt.nativeElement);
} catch {
// It is possible that the clicked element is already not present anymore in the DOM, then isAncestor throws an error.
// In this case assume a click outside to close the keyboard
return false;
}
})
.reduce((a, b) => a || b, false);
if (isFakeInput) {
// don't blur
Expand Down