Skip to content
This repository was archived by the owner on May 9, 2020. It is now read-only.

Conversation

@walac
Copy link
Contributor

@walac walac commented Oct 11, 2019

No description provided.

@walac walac requested a review from djmitche October 11, 2019 12:54
@walac walac self-assigned this Oct 11, 2019
@djmitche
Copy link
Contributor

I just enabled the community-tc-integration bot for this repo (and disabled the old one).

@djmitche djmitche closed this Oct 11, 2019
@djmitche djmitche reopened this Oct 11, 2019
@djmitche
Copy link
Contributor

{
  "AllOf": [
    "docker-worker:cache:docker-worker-garbage-*",
    "docker-worker:capability:privileged",
    "docker-worker:capability:device:loopbackAudio",
    "docker-worker:capability:device:loopbackVideo",
    "secrets:get:repo:github.com/taskcluster/docker-worker:ci-creds",
    "secrets:get:repo:github.com/taskcluster/docker-worker:pulse-creds"
  ]
}

We're naming secrets within the project, rather than the repo, now. Something like project/taskcluster/testing/docker-worker/{ci,pulse}-creds?

I think the other scopes will need to be added in community-tc-config.

Copy link
Contributor

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(comments above)

@walac walac closed this Oct 11, 2019
@walac walac reopened this Oct 11, 2019
@djmitche
Copy link
Contributor

I think you'll want to add an additional stanza like
https://github.com/mozilla/community-tc-config/blob/185e6799de76997dd1d2a766230a06a7e28c6ad0/generate/repo_access.py#L26-L36

granting the necessary scopes to the docker-worker repo.

@djmitche
Copy link
Contributor

oh I see taskcluster/community-tc-config#10 :)

@walac walac closed this Oct 14, 2019
@walac walac reopened this Oct 14, 2019
@walac walac force-pushed the tc-community branch 6 times, most recently from e5a47fd to f139bce Compare October 17, 2019 14:31
@walac walac closed this Oct 17, 2019
@walac walac reopened this Oct 17, 2019
@walac walac closed this Oct 21, 2019
@walac walac reopened this Oct 21, 2019
@walac walac closed this Oct 21, 2019
@walac walac reopened this Oct 21, 2019
@walac walac closed this Oct 21, 2019
@walac walac reopened this Oct 21, 2019
@walac walac closed this Oct 21, 2019
@walac walac reopened this Oct 21, 2019
@walac walac closed this Oct 21, 2019
@walac walac reopened this Oct 21, 2019
@walac walac force-pushed the tc-community branch 3 times, most recently from 9051998 to 78d75e2 Compare October 22, 2019 21:05
@walac
Copy link
Contributor Author

walac commented Oct 23, 2019

I disabled dind tests, for now, to move forward.

@walac walac mentioned this pull request Oct 23, 2019
taskclusterProxy:
true
env:
TASKCLUSTER_ROOT_URL: https://taskcluster.net
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The worker should set this for you anyway? But, doesn't hurt..

name: "Publish docker-worker docs to https://docs.community-tc.services.mozilla.com/reference/workers/docker-worker"
description: "Upload docker-worker documentation to taskcluster [docs site](https://docs.community-tc.services.mozilla.com/reference/workers/docker-worker)."
owner: '{{ event.head.user.email }}'
source: '{{ event.head.repo.url }}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole task actually doesn't do anything anymore, and could be removed (but again doesn't hurt)

@walac walac merged commit b089a1d into taskcluster:master Oct 23, 2019
@walac walac deleted the tc-community branch October 23, 2019 17:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants