Skip to content
This repository was archived by the owner on Feb 20, 2020. It is now read-only.

Bug 1434943 - Update MozillaBuild version to 3.2 for NSS#121

Merged
petemoore merged 1 commit intotaskcluster:masterfrom
martinthomson:update-mozilla-build
Sep 14, 2018
Merged

Bug 1434943 - Update MozillaBuild version to 3.2 for NSS#121
petemoore merged 1 commit intotaskcluster:masterfrom
martinthomson:update-mozilla-build

Conversation

@martinthomson
Copy link
Contributor

We need to run 3.2 if we're going to use the vswhere tool to find VS. That won't change the calculus for these builds, but it's a big usability improvement for contributors.

@martinthomson
Copy link
Contributor Author

Oh, I should point out that this shouldn't be merged until we have merged https://phabricator.services.mozilla.com/D5483 on the NSS side. Otherwise we won't be able to find nsinstall - the reason we stayed with 3.1.1 in the first place.

@coveralls
Copy link

Coverage Status

Coverage decreased (-54.7%) to 15.468% when pulling a42b71e on martinthomson:update-mozilla-build into 68db461 on taskcluster:master.

@petemoore petemoore self-requested a review September 13, 2018 14:17
Copy link
Member

@petemoore petemoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies Martin! I should have asked you to update nss-win2012r2-new instead of nss-win2012r2.

I'll leave this PR open for now, since if all goes well in staging, this PR can roll it out to production, and I'll push the same changes to staging now...

@petemoore
Copy link
Member

@martinthomson I've applied these changes to staging in 654bc76 and am currently running the deploy script to roll it out to production.

In an hour or less the images should be rebuilt and propagated to production, then this patch can be used to run try jobs using Mozilla Build 3.2.

@petemoore petemoore merged commit 7661d65 into taskcluster:master Sep 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants