Skip to content
This repository was archived by the owner on Jan 5, 2019. It is now read-only.

node 5 & npm shrinkwrap & compiled babel#58

Merged
imbstack merged 2 commits intomasterfrom
modern-art
Apr 8, 2016
Merged

node 5 & npm shrinkwrap & compiled babel#58
imbstack merged 2 commits intomasterfrom
modern-art

Conversation

@imbstack
Copy link
Contributor

@imbstack imbstack commented Apr 7, 2016

This is almost assuredly going to break when we deploy it in some way or another, but it does get us shrinkrwapped packages. Things I've done to see if this works so far:

  • the tests pass
  • npm run checkStaging and npm run checkStagingSetup still work
  • I've remembered to update the Procfile this time

Things I'm not really sure about:

  • I've left a couple of things that really did seem like scripts in bin/. Would it make sense for them to be moved to src/ as well? (load-test.js and make-check-client.js)

Roping @jonasfj in as well in case he has any useful input here.

@djmitche djmitche assigned jonasfj and unassigned djmitche Apr 7, 2016
@djmitche
Copy link
Contributor

djmitche commented Apr 7, 2016

Looks good to me, but I feel like what I did looked good too and didn't work, so I'll defer to Jonas

@jonasfj
Copy link
Contributor

jonasfj commented Apr 8, 2016

r+

Looks really good...

@imbstack imbstack merged commit bc2218e into master Apr 8, 2016
@imbstack imbstack deleted the modern-art branch April 8, 2016 19:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants