This repository was archived by the owner on Jan 5, 2019. It is now read-only.
Conversation
djmitche
reviewed
Nov 11, 2016
| // Make result compatibility with how EC2 metadata service let's instances | ||
| // access IAM roles | ||
| if (req.query.format === 'iam-role-compat') { | ||
| return res.status(200).json({ |
Contributor
There was a problem hiding this comment.
This avoids the schema validation.. clever :)
djmitche
reviewed
Nov 11, 2016
| debug("### s3.putObject"); | ||
| await s3.putObject({ | ||
| Bucket: bucket, | ||
| Key: 'folder1/' + id, |
Contributor
There was a problem hiding this comment.
why create a new object on every test run?
Contributor
Author
There was a problem hiding this comment.
to avoid consistency issues... this uses the garbage bucket where everything expires after 24 hours.
djmitche
approved these changes
Nov 11, 2016
Contributor
why does DNS suck? |
Contributor
Author
Not a DNS issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=1316698