Remove task-specific schema from hook.task#77
Conversation
djmitche
left a comment
There was a problem hiding this comment.
I'll post a longer comment about this issue in the bug, but for the moment, a quick note about commits and pull requests. A pull request and commit message should describe what is changing directly, rather than just referring to a bug. The title of this PR, "fixes Bug 1438019", doesn't tell me much (I don't remember what that bug number refers to!).
We have some guidelines in our documentation. Those are pretty common to git-based open source projects, not just Taskcluster, so a good skill to learn.
djmitche
left a comment
There was a problem hiding this comment.
This looks great!
Two things to add:
- a test that calls createTask with some nonsense in the
taskproperty, just to check titleanddescriptionattributes in the schemas for the task indicating that thetaskproperty is a task template, which will be rendered with JSON-e as described in https://docs.taskcluster.net/reference/core/taskcluster-hooks/docs/firing-hooks
djmitche
left a comment
There was a problem hiding this comment.
I added a little bit more text to the description :)
|
@djmitche the test that calls createTask still needs to be added, right? Thanks :) |
|
Oh right! Please make a new PR for that. Silly me!! |
|
Sure. Thanks a lot! |
This is in reference to Bug 1438019 which requires updating the current schemas in accordance with JSON-e so that hook.task has
type: object.