Add URL patterns to README.md #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imbstack
approved these changes
Jun 1, 2018
Contributor
There was a problem hiding this comment.
This looks good other than that it also exists at https://github.com/taskcluster/taskcluster-lib-urls/blob/master/docs/urls-spec.md. Can we either remove that one or link them or... something? I think they will get out of date with each other otherwise.
djmitche
force-pushed
the
add-patterns-to-readme
branch
from
006cfe9 to
088b346
Compare
Contributor
Author
|
So it didn't really "look good" :) I added a note to the README, and updated the markdown in the document to be a bit clearer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be useful to me -- as I build services, I need to look at the source to remember if it's
/referenceor/referencesfor example.