Skip to content
This repository was archived by the owner on Jan 5, 2019. It is now read-only.

add preview and writeFile options#31

Merged
imbstack merged 2 commits intomasterfrom
json-schema-previews
Jan 10, 2017
Merged

add preview and writeFile options#31
imbstack merged 2 commits intomasterfrom
json-schema-previews

Conversation

@jhford
Copy link
Copy Markdown
Contributor

@jhford jhford commented Jan 9, 2017

This is to aid in local debugging as well as to make it possible to process a JSON schema file on the command line

jhford added 2 commits January 9, 2017 16:00
This is to aid in local debugging as well as to make it possible to process a JSON schema file on the command line
@jhford jhford requested a review from jonasfj January 9, 2017 15:10
Comment thread package.json
"ajv": "^4.0.4",
"app-root-dir": "^1.0.2",
"aws-sdk": "^2.2.38",
"aws-sdk": "^2.5.3",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure how this crept in, but i don't see it being a problem...

@jonasfj
Copy link
Copy Markdown
Contributor

jonasfj commented Jan 9, 2017

I can't see the danger of adding this... I still think it would be more appropriate to add this functionality in tc-lib-docs...

I quickly looked at tc-lib-docs, but it has a long list of problems... such as using streams without being streaming, and not supporting retries, we probably need to spend a little more time on tc-lib-docs..

@imbstack what do you think? Wouldn't it be easier to do this through tc-lib-docs?

@jonasfj jonasfj requested a review from imbstack January 9, 2017 20:28
Copy link
Copy Markdown
Contributor

@jonasfj jonasfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like @imbstack thoughts...

I don't oppose the idea, just thinking it's better added in tc-lib-docs, when we want to remove publishing from tc-lib-validate/api/pulse-publisher

@jhford
Copy link
Copy Markdown
Contributor Author

jhford commented Jan 10, 2017

This is nothing to do with docs, this is a debugging tool for working on something which uses lib-validate. Since lib-validate and thus taskcluster use non-standard json-schema formats, it's really nice to have the lib-validate library be self-standing for anyone who wishes to interoperate with taskcluster without having to use lib-docs to do basic debugging.

@jonasfj
Copy link
Copy Markdown
Contributor

jonasfj commented Jan 10, 2017

Fair point... And yeah, I don't really see an danger in adding it to this library.

@imbstack imbstack merged commit 17795c5 into master Jan 10, 2017
@imbstack imbstack deleted the json-schema-previews branch January 10, 2017 16:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants