Skip to content
This repository was archived by the owner on Feb 27, 2020. It is now read-only.

Don't try to use %s in logging#274

Merged
jonasfj merged 1 commit intomasterfrom
logging-no-fmt
May 10, 2017
Merged

Don't try to use %s in logging#274
jonasfj merged 1 commit intomasterfrom
logging-no-fmt

Conversation

@djmitche
Copy link
Contributor

The log functions just concatenate their arguments, rather than
formatting them.

The log functions just concatenate their arguments, rather than
formatting them.
@djmitche djmitche requested a review from jonasfj May 10, 2017 13:31
@coveralls
Copy link

coveralls commented May 10, 2017

Coverage Status

Coverage decreased (-0.06%) to 48.901% when pulling 5518b15 on logging-no-fmt into 040d2f0 on master.

Copy link
Contributor

@jonasfj jonasfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have Infof(), etc.. that does the right thing with formatting... I often try to use these because whitespace is less arbitrary...

@jonasfj jonasfj merged commit e4ff22d into master May 10, 2017
@jonasfj jonasfj deleted the logging-no-fmt branch May 10, 2017 16:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants