Skip to content

Bug 1630023 - utility functions#2717

Merged
djmitche merged 2 commits intotaskcluster:masterfrom
djmitche:bug1630023-utils
Apr 30, 2020
Merged

Bug 1630023 - utility functions#2717
djmitche merged 2 commits intotaskcluster:masterfrom
djmitche:bug1630023-utils

Conversation

@djmitche
Copy link
Copy Markdown
Collaborator

Bugzilla Bug: 1630023

This adds some utility functions that will be useful for phase 2 of the postgres migration work. Specifically, functions for encoding/decoding azure-entities-style base64 blobs, and functions for encoding/decoding azure-entities' urlencoding-like !xx encoding. All have extensive tests.

@djmitche djmitche requested review from a team as code owners April 23, 2020 21:54
@helfi92 helfi92 self-requested a review April 23, 2020 21:56
@djmitche djmitche marked this pull request as draft April 24, 2020 14:02
@djmitche
Copy link
Copy Markdown
Collaborator Author

We're going to add some additional utilities here. I'll also look at the failures.

@djmitche
Copy link
Copy Markdown
Collaborator Author

Thanks to @helfi92 for the two additional utility functions supporting composite keys.

@djmitche djmitche marked this pull request as ready for review April 24, 2020 16:21
Copy link
Copy Markdown
Contributor

@imbstack imbstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

Comment thread libraries/postgres/src/Database.js
Comment thread db/test/versions/0008_test.js
@djmitche djmitche force-pushed the bug1630023-utils branch 2 times, most recently from 1e7fc90 to effb4af Compare April 24, 2020 22:23
Copy link
Copy Markdown
Contributor

@helfi92 helfi92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djmitche
Copy link
Copy Markdown
Collaborator Author

@taskcluster/security-folks did you want to take a look?

The functios that need to be redefined when downgrading from version n+1
to version n are those which were redefined in version n+1 -- and their
definitions may not be in version n. So this searches backward through
all versions to find the appropriate function definition.
@djmitche djmitche merged commit a00c552 into taskcluster:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants