feat(github): Allow to skip CI for some commits.#5612
Conversation
|
This is currently implemented for the "push" events with a single commit in it only. I'm not sure if we should also support pull requests with titles that includes "[ci skip]" keyword. |
|
I like it. One thing I'd like to call out is that in general, interpretation of commit messages is likely to be project-specific, so I think taskgraph is a better place to interpret directives in commit messages for anything else we add, but for the one and only case of skipping tasks, it indeed needs to be either json-e or the taskcluster github service that does this, since taskgraph requires that a task is already running. |
5288942 to
62d28de
Compare
For a single commit push event with a message that contains "[skip ci]" or "[ci skip]" no tasks would be created. Fixes #5311
62d28de to
a5444c7
Compare
petemoore
left a comment
There was a problem hiding this comment.
Love it, thanks for adding the tests too!
For a single commit push event with a message that contains
"[skip ci]"or"[ci skip]"no tasks would be created.Fixes #5311