fix(run-task): stop cleaning up fetches dir #867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleanup is problematic because it can fail if there are resources under the fetches dir that are still being used by subprocesses spawned by the task. The cleanup was added ~7 years ago to workaround fetches getting re-used on a generic-worker simple engine task. These days, everything should be using the multiuser engine which means tasks get entirely separate users and there's no possibility of accidentally re-using fetches between tasks. Also the Gecko `run-task` dropped this cleanup ~5 years ago.
jcristau
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleanup is problematic because it can fail if there are resources under the fetches dir that are still being used by subprocesses spawned by the task.
The cleanup was added ~7 years ago to workaround fetches getting re-used on a generic-worker simple engine task. These days, everything should be using the multiuser engine which means tasks get entirely separate users and there's no possibility of accidentally re-using fetches between tasks.
Also the Gecko
run-taskdropped this cleanup ~5 years ago.