fix: remove unused 'requires-python' and add lower bounds to workspace members#898
Merged
ahal merged 1 commit intotaskcluster:mainfrom Feb 4, 2026
Merged
fix: remove unused 'requires-python' and add lower bounds to workspace members#898ahal merged 1 commit intotaskcluster:mainfrom
ahal merged 1 commit intotaskcluster:mainfrom
Conversation
Eijebong
reviewed
Feb 4, 2026
Contributor
Eijebong
left a comment
Eijebong
left a comment
There was a problem hiding this comment.
requires-python doesn't have any effect in members of a workspace. The one at the root is the only one that is taken into account which explains why the lockfile diff is so tiny, the only changes are the new bounds you added.
Collaborator
Author
|
Ohh, that makes sense.. I'll delete them then. |
ahal
changed the title
Eijebong
approved these changes
Feb 4, 2026
| dependencies = ["pytest", "taskcluster-taskgraph>=12.1.0"] | ||
| dependencies = [ | ||
| "pytest>=8.4.2", | ||
| "taskcluster-taskgraph>=12.1.0"] |
Contributor
There was a problem hiding this comment.
nit
Suggested change
| "taskcluster-taskgraph>=12.1.0"] | |
| "taskcluster-taskgraph>=12.1.0", | |
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We neglected this when dropping support for 3.8 in the main package. Also adds minimum bounds for dependencies there, which impacts
uv run --resolution.