fix: ignore '__pycache__' dirs when generating docker contexts#908
Merged
abhishekmadan30 merged 1 commit intotaskcluster:mainfrom Feb 17, 2026
Merged
fix: ignore '__pycache__' dirs when generating docker contexts#908abhishekmadan30 merged 1 commit intotaskcluster:mainfrom
abhishekmadan30 merged 1 commit intotaskcluster:mainfrom
Conversation
It looks like we're modifying an unused variable, but modifying the list in-place changes `os.walk`'s behaviour. This seems a bit hacky, but this exact use case is actually used in the official documentation as an example.
ahal
force-pushed
the
ahal/push-qqxmzzmzxovv
branch
from
218adad to
d062312
Compare
Collaborator
Author
|
Maybe this should be using tracked files instead? Should still be an improvement at least. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like we're modifying an unused variable, but modifying the list in-place changes
os.walk's behaviour. This seems a bit hacky, but this exact use case is actually used in the official documentation as an example.