Support defining Schemas as dicts#939
Merged
ahal merged 3 commits intotaskcluster:mainfrom Apr 24, 2026
Merged
Conversation
This provides an alternative way to define schemas, which IMO looks a bit nicer than the class based approach. One big benefit of this method is that you can use dashes in the keys, so it's possible to use both underscores and dashes as identifiers and it's clear to the user which is which.
ahal
force-pushed
the
ahal/push-kmvltlksysly
branch
from
dbb6873 to
f954448
Compare
ahal
force-pushed
the
ahal/push-kmvltlksysly
branch
from
f954448 to
16e4273
Compare
hneiva
approved these changes
Apr 24, 2026
Contributor
hneiva
left a comment
hneiva
left a comment
There was a problem hiding this comment.
Not super familiar with how MsgSpec Schemas work, but LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Msgspec schemas are much faster, but I find the struct based definitions to look clunky, especially with many nested structs. This uses
msgspec.defstructto support defining schemas as a dictionary, somewhat similar to how the voluptuous schemas used to look.I converted one file (
from_deps.py) as an example of what the new format looks like. Will update the rest in a follow-up PR.