feat!: convert parameter schema from voluptuous to msgspec#940
Merged
abhishekmadan30 merged 2 commits intotaskcluster:mainfrom May 1, 2026
Merged
feat!: convert parameter schema from voluptuous to msgspec#940abhishekmadan30 merged 2 commits intotaskcluster:mainfrom
abhishekmadan30 merged 2 commits intotaskcluster:mainfrom
Conversation
abhishekmadan30
added
the
BREAKING CHANGE
abhishekmadan30
force-pushed
the
parameter-schema
branch
2 times, most recently
from
a498061 to
07a766f
Compare
ahal
requested changes
Apr 29, 2026
Collaborator
ahal
left a comment
ahal
left a comment
There was a problem hiding this comment.
Thanks, looks good!
I'd like to standardize on the from_dict format though, so maybe we can land new code in that format.
abhishekmadan30
force-pushed
the
parameter-schema
branch
from
07a766f to
7a09e43
Compare
Collaborator
|
One minor nit, but if we're following conventional commits, the prefix should be in the commit body. No big deal because we don't enforce it here, so more of an fyi |
abhishekmadan30
force-pushed
the
parameter-schema
branch
from
7a09e43 to
e967d18
Compare
abhishekmadan30
changed the title
abhishekmadan30
force-pushed
the
parameter-schema
branch
2 times, most recently
from
ac51cf1 to
b3e0a05
Compare
abhishekmadan30
force-pushed
the
parameter-schema
branch
from
b3e0a05 to
85e74c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.