Skip to content

Conversation

@roggervalf
Copy link
Collaborator

@roggervalf roggervalf commented Dec 26, 2025

Why

  1. Why is this change necessary? Deduplication option was removed but debounce option is also doing same logic. This must be removed as well. Additionally removing deduplication logic from addParent script as flow producer uses this script and this functionality is not supported

How

Enter the implementation details here.

Additional Notes (Optional)

Any extra info here.

Copilot AI review requested due to automatic review settings December 26, 2025 17:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the deprecated debounce option from flow producers in BullMQ. The debounce option was already deprecated in favor of the deduplication option, and this PR enforces that parent and child jobs in flows cannot use debounce functionality.

Key changes:

  • Updated TypeScript interfaces to explicitly omit 'debounce' from FlowJobBase and FlowChildJob types
  • Removed deduplication/debounce logic from the addParentJob Lua script
  • Removed test case that verified debounce behavior in flows
  • Added non-null assertion operators where needed due to stricter typing

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/interfaces/flow-job.ts Added 'debounce' to the Omit type for both FlowJobBase and FlowChildJob, preventing debounce option usage in flows
src/commands/addParentJob-6.lua Removed deduplicateJob function call and include directive, eliminating debounce/deduplication logic for parent jobs
tests/test_flow.ts Removed test case for debounced child jobs and added non-null assertion operators to handle stricter typing from interface changes
docs/gitbook/guide/flows/README.md Updated type definitions in documentation to reflect that debounce is now omitted from flow job options

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@roggervalf roggervalf requested a review from manast December 26, 2025 18:15
@roggervalf roggervalf merged commit cc74805 into master Dec 27, 2025
20 checks passed
@roggervalf roggervalf deleted the fix-flow-debounce branch December 27, 2025 21:29
@github-actions
Copy link
Contributor

🎉 This PR is included in version 5.66.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants