F-Droid build failed

[linsui]

com.microsoft.identity.client:msal depends on gms and exclude doesn't work. The gms classes are still build into the apk. We need to either remove this lib or fork it and remove the gms dep.

[abaker]

I haven't been able to find the f-droid build log so I didn't see the exact error. The gms classes shouldn't be in the runtime classpath:

tasks/deps_fdroid.txt

Line 1416 in 08fa635

++--- com.microsoft.identity.client:msal:6.0.1

The build metadata is likely deleting the exclude and re-introducing the library here:

https://gitlab.com/fdroid/fdroiddata/-/blob/master/metadata/org.tasks.yml#L2890

msal is necessary to support Microsoft To Do work and school accounts. The way microsoft does oauth for these accounts is incompatible with AppAuth (#3267). If necessary I could just use AppAuth and personal accounts in F-Droid

[linsui]

The log is here. https://gitlab.com/fdroid/fdroiddata/-/jobs/9970164252 I tweaked the build script to make sure the exclude line is not removed. We check the apk with dexdump and it finds these gms classes.

[abaker]

I do see they're making it into the final APK for some reason, but I haven't been able to figure out why, or how to prevent it with gradle. I'll see if I can figure it out, and if not I'll just use AppAuth for fdroid

[abaker]

Removed microsoft authentication library from F-Droid build: a4ca8b2

[linsui]

Thanks! This is not included in 14.7.1 and we need to wait for the next version, right?

[abaker]

Yeah 14.7.1 was already rolling out, but I'll try to do another release soon