Auto-mirror some icons according to guidelines#1391
Auto-mirror some icons according to guidelines#1391triallax wants to merge 1 commit intotasks:mainfrom
Conversation
Note that I'm not an expert and may have made some mistake. Guidelines link: https://material.io/design/usability/bidirectionality.html#mirroring-elements
|
Should the left and right arrows be mirrored too? I only mirrored the back arrow. |
Codecov Report
@@ Coverage Diff @@
## main #1391 +/- ##
=======================================
Coverage 13.77% 13.77%
=======================================
Files 505 505
Lines 21622 21622
Branches 3969 3969
=======================================
Hits 2978 2978
+ Misses 17894 17893 -1
- Partials 750 751 +1
Continue to review full report at Codecov.
|
|
Thanks, I merged these in 4574a5a. I added mirrors for a couple more movement related ones too (ic_airport_shuttle_24px and ic_outline_directions_walk_24px) What are your thoughts on these two:
|
|
For the chart icon, I'm not really sure, but I think you can go ahead and mirror it. For the undo icon, I agree that the docs are unclear. Does the undo icon represent going back in time? Or does it represent putting something "back" to how it was? I guess you can mirror it for now, but it probably needs more examination later. Also, quoting from above since you seemed to have missed it:
|
|
Sorry, I wasn't sure about those. I just added mirroring back for the arrows, chart, undo, and the subdirectory back button (1f7cb2a). Hopefully someone will complain if anything is wrong |
Follow-up to #1387.
Guidelines: https://material.io/design/usability/bidirectionality.html#mirroring-elements
I'm not an expert on this topic, so it would be great if someone more knowledgeable about this would take a quick look and see if I made any mistake.