Conversation
* Add RealityKit Support * fix typo * replace NSError with VRMError * refine error message * remove unnecessary #available(iOS 18.0, *) * fix warning for enableNormalTangentBlendShape * Remove compactVertices function and rename compactVerticesDisabled to a more appropriate name * rename source signatures * support visionos * add visionOS to Makefile * Make test destinations select latest simulator runtime
Summary of ChangesHello @tattn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for visionOS by adding a new target and integrating RealityKit for VRM model rendering. It also restructures the project to accommodate the new platform and improves UI navigation with a tab bar interface, enhancing the app's organization and expanding its platform reach. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces significant changes by adding RealityKit and visionOS support, expanding the project's platform compatibility. The changes involve updating the Xcode project configuration, modifying the main storyboard for a tab bar interface, and adding a new VisionExample target with SwiftUI views for visionOS. A new VRMRealityKit library is also introduced, providing a comprehensive set of tools for loading and rendering VRM models in RealityKit. Overall, the changes are well-structured and demonstrate a clear effort to integrate new Apple technologies. The addition of the VRMRealityKit library is a substantial and valuable contribution, providing detailed implementations for handling VRM model components like blend shapes, humanoids, and spring bones within the RealityKit framework. There are a few areas for improvement regarding consistency and potential edge cases in the newly added RealityKit code.
- Removed boilerplate comments from various Swift files in VRMKit, VRMRealityKit, and VRMSceneKit. - Cleaned up imports and ensured consistent formatting. - Updated file headers to improve readability and maintainability.
… version requirement
|
@codex please review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0231ae7a9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c9c4c97c9e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
tattn
force-pushed
the
feature/realitykit
branch
from
9bf16ab to
22d1b62
Compare
2 participants
This pull request updates the Xcode project to add a new visionOS target called
VisionExample, along with its associated files and configuration. It also updates the main storyboard to set up a tab bar interface, including a tab for the existing SceneKit view controller. The changes improve project organization and expand platform support.New visionOS target and related project configuration:
VisionExample, to the Xcode project with its own group, build phases, and build configurations for Debug and Release. This includes new files:VisionExampleApp.swift,ContentView.swift, and anInfo.plist. [1] [2] [3]VRMRealityKitSwift package, set deployment target to visionOS 1.0, and updated supported platforms and device families. [1] [2] [3]VRMRealityKitproduct. [1] [2]Project structure and build settings:
VisionExample. [1] [2] [3]This pull request introduces significant enhancements to the example Xcode project, most notably by adding support for visionOS and improving the CI workflow. The changes include the addition of a new "VisionExample" target and associated files, updates to the project structure and build configurations, and improvements to the CI to test across multiple Apple platforms.
visionOS Support and Example Expansion:
Added a new
VisionExampletarget to the Xcode project, including new source files (VisionExampleApp.swift,ContentView.swift), its ownInfo.plist, and a dedicated product bundle identifier. This target is configured to use theVRMRealityKitpackage and is set up for visionOS deployment. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Updated the project structure to include the new
VisionExamplegroup and linked resources, and added the necessary build phases and configurations for the new target. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Integrated the new
VRMRealityKitSwift package product as a dependency for both the existing and new targets, ensuring compatibility across iOS, watchOS, and visionOS. [1] [2] [3] [4] [5] [6]CI Workflow Improvements:
macos-26for broader compatibility. The workflow now usesxcbeautifyfor improved log output and invokes platform-specific test commands.Other Project Updates:
objectVersionto 60 for compatibility with newer Xcode versions.AppDelegate.swift.cfff8f319c1b88c851d55854d1ac630697cebR487-R489) [6]Storyboard and UI changes:
Main.storyboardto a tab bar controller, and added a tab bar item for the SceneKit view controller, improving the app's navigation structure. [1] [2]Big Thanks: @tatsuya-ogawa #36
related: #28 #34 #35
This pull request introduces significant updates to the example Xcode project, primarily adding support for visionOS (xrOS) and improving CI test coverage for multiple Apple platforms. The most important changes include the creation of a new visionOS example target and app, integration of the
VRMRealityKitpackage, and enhancements to the CI workflow to test across iOS, watchOS, and xrOS.visionOS (xrOS) Support:
Added a new
VisionExampletarget and app to the Xcode project, including new source files (VisionExampleApp.swift,ContentView.swift), resources, and anInfo.plistconfigured for visionOS deployment. This enables building and running the example on Apple Vision Pro and xrOS Simulator. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Updated build configurations and deployment targets to support visionOS, including setting
SDKROOT = xros,SUPPORTED_PLATFORMS = "xros xrsimulator", and addingXROS_DEPLOYMENT_TARGET. [1] [2]Dependency and Framework Integration:
VRMRealityKitSwift package into both the main and visionOS example targets, allowing use of RealityKit-based features in the new app. [1] [2] [3] [4] [5]CI Workflow Improvements:
xcbeautifyfor improved output formatting.Project Structure and Modernization:
objectVersionto 60 and added new source/resource file references for the visionOS app. [1] [2] [3]Minor Updates:
RKM-Tab-001and updated the tab bar item for clarity. [1] [2]AppDelegate.swiftfor brevity.