Make gtk an optional feature#283
Merged
amrbashir merged 2 commits intotauri-apps:devfrom Mar 22, 2025
Merged
Conversation
Contributor
Author
|
(Note that this is actually a breaking change for it will break the Linux build if one did |
amrbashir
requested changes
Mar 7, 2025
Member
amrbashir
left a comment
amrbashir
left a comment
There was a problem hiding this comment.
Thank you, could you please add a change file in .changes directory? and update the Cargo features section in README.md?
Cargo.toml
Outdated
| default = ["libxdo"] | ||
| libxdo = ["dep:libxdo"] | ||
| default = ["libxdo", "gtk"] | ||
| libxdo = ["dep:libxdo", "gtk"] |
Member
There was a problem hiding this comment.
i think this can stay as is
Suggested change
| libxdo = ["dep:libxdo", "gtk"] | |
| libxdo = ["dep:libxdo"] |
This helps projects that uses muda on platform other than Linux to not get the gtk dependencies in their Cargo.lock (and the security advisories that goes with it) Fixes tauri-apps#282
amrbashir
reviewed
Mar 8, 2025
This should be a minor since breaking changes are allowed in minor releases for 0.x versions Co-authored-by: Amr Bashir <github@amrbashir.me>
Contributor
Author
|
Thanks for merging. |
Member
|
I wanted to make the transition to gtk4 in this release but with my lack of time and effort involved, I guess that is not possible. That said, I plan to make a release this week, just need one more PR to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps projects that uses muda on platform other than Linux to not get the gtk dependencies in their Cargo.lock (and the security advisories that goes with it)
Fixes #282