fix(persisted-scope): fix patterns usage (fix #25)#32
Closed
OrIOg wants to merge 0 commit into
Closed
Conversation
JonasKruckenberg
pushed a commit
that referenced
this pull request
Jan 11, 2023
chore(deps): update dependency rollup to v2.65.0
|
I think I have this issue. Should we wait for a merge or I can apply this patch somehow ? |
Member
|
We can't merge it as long as it depends on a git version of tauri (and it would be ideal if we can implemented it in a way that does not need a tauri update to not break apps that can't upgrade tauri for some reason - that part is not a requirement) |
OrIOg
force-pushed
the
persisted-scope-fix
branch
2 times, most recently
from
3d11b41 to
a305ad3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Draft for fixing #25(explanation)
Current change breaks old
.persistent-scopefiles deserialization.Can be fixed by moving the pattern conversion in deserialization.
Using metadata with Tauri v1.
Suggestion for Tauri v2
Could be easier/cleaner if
FsScopeEventgave the "type" of allowed path(i.e : file, directory, recursive directory).Might want to make a PR in Tauri itself.
As a Rust/Tauri neophyte, there must be a better way to handle that mutex/remove it.
Might be fixable when if we reuse the old serialization method if we move the pattern conversion in deserialization.
Any suggestions are welcome