Fix empty custom show/hide url excludes home route "/"#12
Merged
eug-L merged 2 commits intotawk:masterfrom Jul 24, 2024
Merged
Conversation
eug-L
commented
Jul 23, 2024
| $value = (empty($value)||!$value)?array():$value; | ||
| $jsonOpts[$column] = json_encode($value); | ||
| // split by newlines, then remove empty lines | ||
| $value = str_replace("\r", "\n", $value); |
Contributor
Author
There was a problem hiding this comment.
no urldecode() here because form is not serialized, actual string is posted via form action
pyhrus
approved these changes
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous logic doesn't remove empty strings from array, causing home route to be excluded from show/hide rules