Skip to content

Comments

docs: Updated Keycloak configuration document for multi-tenancy#239

Merged
Sandy-at-Tazama merged 12 commits intodevfrom
feat-multi-tenancy
Aug 4, 2025
Merged

docs: Updated Keycloak configuration document for multi-tenancy#239
Sandy-at-Tazama merged 12 commits intodevfrom
feat-multi-tenancy

Conversation

@Abdullah-Siddiqui-Paysys
Copy link
Contributor

SPDX-License-Identifier: Apache-2.0

What did we change?

Updated README.md for the configuration steps related to the addition of TENANT_ID to Keycloak.

Why are we doing this?

To implement multi-tenancy in Tazama.

How was it tested?

  • Locally
  • Development Environment
  • Not needed, changes very basic
  • Husky successfully run
  • Unit tests passing and Documentation done

Copy link
Contributor

@Sandy-at-Tazama Sandy-at-Tazama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The terminology used to describe configuring the tenant ID refers to claims - I understood the mechanism used is an attribute of a group which is not a claim. Please confirm

@UmairKhan-Paysys UmairKhan-Paysys changed the title Updated README.md feat: Updated Keycloak configuration document for multi-tenancy Jul 29, 2025
@UmairKhan-Paysys UmairKhan-Paysys changed the title feat: Updated Keycloak configuration document for multi-tenancy docs: Updated Keycloak configuration document for multi-tenancy Jul 29, 2025
Copy link
Contributor

@Sandy-at-Tazama Sandy-at-Tazama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The licensing header should be at the top of the file (line 1). See guideline here https://github.com/tazama-lf/docs/blob/dev/Guides/definition-of-done.md

Copy link
Contributor

@Sandy-at-Tazama Sandy-at-Tazama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The licensing header on line 1 should be a comment <!-- SPDX-License-Identifier: Apache-2.0 -->; please delete the duplicate on line 6

@Sandy-at-Tazama Sandy-at-Tazama requested review from Sandy-at-Tazama and removed request for Sandy-at-Tazama August 4, 2025 09:52
@Sandy-at-Tazama Sandy-at-Tazama self-requested a review August 4, 2025 09:54
@Sandy-at-Tazama Sandy-at-Tazama merged commit 3c5d5a4 into dev Aug 4, 2025
@Sandy-at-Tazama Sandy-at-Tazama deleted the feat-multi-tenancy branch August 4, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants