test(windows): resolve test failures with platform-agnostic assertions #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Three issues causing 29 Windows CI failures:
1. pyfakefs root directory conflict: fake_tree fixture defaulted to Path("/")
which becomes C:\ on Windows pyfakefs, but C:\ already exists as a mount
point. Changed default to Path("/fake_root").
2. Path separator in __str__ assertion: test_str_shows_scope_path_pairs
expected forward slashes but Windows uses backslashes. Now uses f-strings
with Path objects for platform-correct comparison.
3. Exception message path format: PatternFileError tests hardcoded forward
slashes in expected strings. Now constructs expected dynamically using
the same Path object.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
…ry errors - Add Windows-specific test using monkeypatch for permission denied error since chmod doesn't restrict access on Windows - Add Windows-specific test for directory error since pyfakefs raises PermissionError instead of IsADirectoryError on Windows - Use skipif markers to run correct test variant per platform
complexipy (Rust-based) fails to compile on Windows with free-threaded Python 3.14t due to missing python314.lib for Rust linking. Since linting with complexipy runs on Ubuntu in the lint job, excluding it from Windows test jobs has no coverage impact.
tbhb
added a commit
that referenced
this pull request
Jan 12, 2026
#3) * test(windows): resolve test failures with platform-agnostic assertions Three issues causing Windows CI failures: 1. pyfakefs root directory conflict: fake_tree fixture defaulted to Path("/") which becomes C:\ on Windows pyfakefs, but C:\ already exists as a mount point. Changed default to Path("/fake_root"). 2. Path separator in __str__ assertion: test_str_shows_scope_path_pairs expected forward slashes but Windows uses backslashes. Now uses f-strings with Path objects for platform-correct comparison. 3. Exception message path format: PatternFileError tests hardcoded forward slashes in expected strings. Now constructs expected dynamically using the same Path object. * test(windows): add platform-specific tests for permission and directory errors - Add Windows-specific test using monkeypatch for permission denied error since chmod doesn't restrict access on Windows - Add Windows-specific test for directory error since pyfakefs raises PermissionError instead of IsADirectoryError on Windows - Use skipif markers to run correct test variant per platform * build: exclude complexipy from Windows complexipy fails to compile on Windows with free-threaded Python 3.14t due to missing python314.lib for Rust linking. * chore: use Python 3.13 for development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 29 Windows CI test failures by making test assertions platform-agnostic.
Three issues resolved:
pyfakefs root directory conflict -
fake_treefixture defaulted toPath("/")which becomesC:\on Windows pyfakefs, butC:\already exists as a mount point causingFileExistsError. Changed default toPath("/fake_root").Path separator in
__str__assertion -test_str_shows_scope_path_pairsexpected forward slashes (/project) but Windows uses backslashes (\project). Now uses f-strings with Path objects for platform-correct comparison.Exception message path format -
PatternFileErrortests hardcoded forward slashes in expected strings. Now constructs expected dynamically using the same Path object.Test plan