Markup: Print styles for slashed corner cell #3550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
added
the
markup
michaelficarra
approved these changes
Mar 19, 2025
syg
approved these changes
Mar 19, 2025
bakkot
approved these changes
Mar 28, 2025
bakkot
added
the
ready to merge
ljharb
force-pushed
the
print-slashed-cell
branch
from
f068482 to
4172303
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overlapping background gradient is fun in Chrome, but it ends up a blurry mess against vector table borders in the PDF. Also the CSS spec apparently doesn’t actually define behavior for non-static positioning within table cells? So implementations vary. Prince’s isn’t great. (idk, i read this somewhere, i didn’t dig in to the spec because it doesn’t really matter)
Anyway here’s a base64-encoded SVG. It’s only on Table 48, as that’s how I found it.
IMO you should put this in ecmarkup, it could be useful for other publications. But you do you boo.