Lint against re-declaring parameters#679
Merged
Conversation
bakkot
approved these changes
Mar 22, 2026
Member
bakkot
left a comment
There was a problem hiding this comment.
The change to ValidateAndApplyPropertyDescriptor SGTM. Want to open and land that change first, then we can land this?
michaelficarra
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linting for tc39/ecma262#3768. This is probably not going to catch every single case, but it should catch the majority.
With this change we get a false positive in ValidateAndApplyPropertyDescriptor step 6.c.i:
because Desc is the first variable defined after for each, so ecmarkup thinks that we are re-declaring it. It would report the same error for this algorithm, even if Desc was not a parameter:
If we want to lint for re-declared parameters, we can update that loop to instead do something like
so that ecmarkup doesn't think that that step is declaring Desc.